Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where the wrong deletion date was shown in recycle bin #6078

Merged

Conversation

ufoloko
Copy link
Contributor

@ufoloko ufoloko commented Jun 21, 2024

This PR Fixes #6074

Actually when you go to recycle bin section, on modules tab, date showed is supposed to be deletion date for each modules, but is not the correct date, because is taking LastModifiedDate for module besides LastModifiedDate for TabModule.

PR takes dates from tabmodules table in vw_view

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, for the other reviewers, this is basically the change from current:

image

@valadas valadas changed the title Fixes issue #6074 Fixed an issue where the wrong deletion date was shown in recycle bin Jun 21, 2024
@valadas valadas added this to the 9.13.4 milestone Jun 21, 2024
Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thank you @ufoloko 🎉

@david-poindexter david-poindexter merged commit 03f04a4 into dnnsoftware:develop Jun 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Recycle bin is not showing LastModifiedOnDate date for modules
3 participants